enhance(build)!: add fork field for OIDC #1221
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecrupper
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1221 +/- ##
==========================================
+ Coverage 56.87% 56.89% +0.01%
==========================================
Files 599 599
Lines 32869 32886 +17
==========================================
+ Hits 18695 18709 +14
- Misses 13538 13541 +3
Partials 636 636
|
plyr4
reviewed
Nov 11, 2024
| @@ -191,6 +192,7 @@ func (b *Build) Environment(workspace, channel string) map[string]string { | |||
| envs["VELA_PULL_REQUEST"] = number | |||
| envs["VELA_PULL_REQUEST_SOURCE"] = b.GetHeadRef() | |||
| envs["VELA_PULL_REQUEST_TARGET"] = b.GetBaseRef() | |||
| envs["VELA_PULL_REQUEST_FORK"] = ToString(b.GetFork()) | |||
There was a problem hiding this comment.
is this info attached to pull requests only? or can we do VELA_REPO_FORK and report it on non-PR events too
There was a problem hiding this comment.
the only event that can be triggered on the main repo by content pushed to a fork of that repo is via the PR event. GitHub definitely has metadata about if the repo is a fork, but the only time that really matters is when it's attempting to trigger a build on the parent repo right?
There was a problem hiding this comment.
ohhh i understand what you mean, yeah i get it. sweet
wass3r
approved these changes
Nov 12, 2024
plyr4
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extra context from OIDC proposal: go-vela/community#976 (comment)
This will allow for stricter policies when considering PR builds and their ability to leverage OIDC.