Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update mock to live in server #521

Merged
merged 3 commits into from
Oct 29, 2021
Merged

refactor: update mock to live in server #521

merged 3 commits into from
Oct 29, 2021

Conversation

kneal
Copy link
Contributor

@kneal kneal commented Oct 28, 2021

Related to https://github.com/go-vela/community/blob/master/proposals/2021/08-25_repo-structure.md

Part of the effort for go-vela/community#394

This copies all the server package code from the https://github.com/go-vela/mock repo.

The link to this package is https://github.com/go-vela/mock/tree/master/server.

This is a stepping stone to migrating some of the code from https://github.com/go-vela/mock to this repo.

@kneal kneal added the enhancement Indicates an improvement to a feature label Oct 28, 2021
@kneal kneal self-assigned this Oct 28, 2021
@kneal kneal requested a review from a team as a code owner October 28, 2021 15:16
Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #521 (3d8f4b6) into master (fe90645) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #521   +/-   ##
=======================================
  Coverage   55.17%   55.17%           
=======================================
  Files         178      178           
  Lines       13415    13415           
=======================================
  Hits         7402     7402           
  Misses       5707     5707           
  Partials      306      306           

//
// Use of this source code is governed by the LICENSE file in this repository.

package server

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
5-149 lines are duplicate of mock/server/secret.go:5-168 (dupl)

//
// Use of this source code is governed by the LICENSE file in this repository.

package server

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
5-168 lines are duplicate of mock/server/service.go:5-146 (dupl)

//
// Use of this source code is governed by the LICENSE file in this repository.

package server

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
5-146 lines are duplicate of mock/server/step.go:5-155 (dupl)

//
// Use of this source code is governed by the LICENSE file in this repository.

package server

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
5-155 lines are duplicate of mock/server/user.go:5-131 (dupl)

//
// Use of this source code is governed by the LICENSE file in this repository.

package server

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
5-131 lines are duplicate of mock/server/hook.go:5-149 (dupl)

var body library.Login
_ = json.Unmarshal(data, &body)

c.SetCookie(constants.RefreshTokenName, "refresh", 2, "/", "", true, true)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
mnd: Magic number: 2, in detected (gomnd)

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KellyMerrick KellyMerrick merged commit 4e64f89 into master Oct 29, 2021
@KellyMerrick KellyMerrick deleted the refactor/mock branch October 29, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates an improvement to a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants