-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update mock to live in server #521
Conversation
kneal
commented
Oct 28, 2021
•
edited
Loading
edited
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #521 +/- ##
=======================================
Coverage 55.17% 55.17%
=======================================
Files 178 178
Lines 13415 13415
=======================================
Hits 7402 7402
Misses 5707 5707
Partials 306 306 |
// | ||
// Use of this source code is governed by the LICENSE file in this repository. | ||
|
||
package server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
5-149 lines are duplicate of mock/server/secret.go:5-168
(dupl)
// | ||
// Use of this source code is governed by the LICENSE file in this repository. | ||
|
||
package server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
5-168 lines are duplicate of mock/server/service.go:5-146
(dupl)
// | ||
// Use of this source code is governed by the LICENSE file in this repository. | ||
|
||
package server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
5-146 lines are duplicate of mock/server/step.go:5-155
(dupl)
// | ||
// Use of this source code is governed by the LICENSE file in this repository. | ||
|
||
package server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
5-155 lines are duplicate of mock/server/user.go:5-131
(dupl)
// | ||
// Use of this source code is governed by the LICENSE file in this repository. | ||
|
||
package server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
5-131 lines are duplicate of mock/server/hook.go:5-149
(dupl)
var body library.Login | ||
_ = json.Unmarshal(data, &body) | ||
|
||
c.SetCookie(constants.RefreshTokenName, "refresh", 2, "/", "", true, true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
mnd: Magic number: 2, in detected (gomnd)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm