Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hook): set webhook_id in process webhook function #625

Merged
merged 2 commits into from
Apr 18, 2022

Conversation

ecrupper
Copy link
Contributor

Since #622 will not be merged relatively soon, the piece of that PR that is absolutely necessary is the part where the webhook_id is set during ProcessWebhook. Redelivery can wait.

@ecrupper ecrupper requested a review from a team as a code owner April 15, 2022 15:42
@ecrupper ecrupper self-assigned this Apr 15, 2022
@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #625 (3cb3d99) into master (cb09250) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #625      +/-   ##
==========================================
- Coverage   55.09%   55.09%   -0.01%     
==========================================
  Files         195      195              
  Lines       15723    15729       +6     
==========================================
+ Hits         8663     8666       +3     
- Misses       6699     6701       +2     
- Partials      361      362       +1     
Impacted Files Coverage Δ
scm/github/webhook.go 90.11% <50.00%> (-0.70%) ⬇️

Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one quick change

scm/github/webhook.go Outdated Show resolved Hide resolved
Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants