Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: webhook race condition on pipeline creation #659

Merged
merged 14 commits into from
Jun 15, 2022

Conversation

jbrockopp
Copy link
Contributor

closes go-vela/community#608

Similar to #191

@jbrockopp jbrockopp added the bug Indicates a bug label Jun 13, 2022
@jbrockopp jbrockopp self-assigned this Jun 13, 2022
@jbrockopp jbrockopp marked this pull request as ready for review June 13, 2022 13:19
@jbrockopp jbrockopp requested a review from a team as a code owner June 13, 2022 13:19
@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #659 (c706035) into master (cd5cfd8) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #659      +/-   ##
==========================================
- Coverage   55.15%   55.07%   -0.08%     
==========================================
  Files         195      195              
  Lines       15901    15923      +22     
==========================================
  Hits         8770     8770              
- Misses       6758     6780      +22     
  Partials      373      373              
Impacted Files Coverage Δ
api/webhook.go 0.00% <0.00%> (ø)

Copy link
Contributor

@kneal kneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐬

Copy link
Collaborator

@wass3r wass3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was able to replicate the issue consistently locally with the old code and the changes here are taking care of the issue. thanks for the fix.

@wass3r wass3r merged commit 8c74c47 into master Jun 15, 2022
@wass3r wass3r deleted the fix/webhook/pipeline/race_condition branch June 15, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v0.14 - pipelines create race condition
3 participants