-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: webhook race condition on pipeline creation #659
Conversation
Codecov Report
@@ Coverage Diff @@
## master #659 +/- ##
==========================================
- Coverage 55.15% 55.07% -0.08%
==========================================
Files 195 195
Lines 15901 15923 +22
==========================================
Hits 8770 8770
- Misses 6758 6780 +22
Partials 373 373
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was able to replicate the issue consistently locally with the old code and the changes here are taking care of the issue. thanks for the fix.
closes go-vela/community#608
Similar to #191