-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(compiler): support deployment parameters in templates #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #665 +/- ##
==========================================
+ Coverage 55.14% 55.20% +0.05%
==========================================
Files 201 201
Lines 15882 15916 +34
==========================================
+ Hits 8758 8786 +28
- Misses 6748 6752 +4
- Partials 376 378 +2
|
…:go-vela/server into feature/compiler/templates/deploy_params
kneal
previously approved these changes
Jun 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐬
JordanSussman
approved these changes
Jun 28, 2022
plyr4
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes go-vela/community#568
Related to go-vela/docs#306
This change updates the
golangci-lint
configuration to ignore thewsl
linter for*_test.go
files.This change also adds support for referencing
DEPLOYMENT_PARAMETER_*
variables in a template.In a Go template, you'll be able to reference these parameters using the existing
vela
platform function:{{ vela "DEPLOYMENT_PARAMETER_<NAME>" }}
In a Starlark template, you'll be able to reference these parameters using the existing
vela
platform function:ctx["vela"]["deployment"]["<name>"]
This was tested utilizing the following deployment command:
And using the following root Vela pipeline:
The
test.yml
file had the following content:The
test.star
file had the following content: