Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(linter): fix the golangci-lint errors #693

Merged
merged 4 commits into from
Sep 14, 2022
Merged

chore(linter): fix the golangci-lint errors #693

merged 4 commits into from
Sep 14, 2022

Conversation

ecrupper
Copy link
Contributor

Addressed:

  • nolint leading spacing issue
  • gofmt ran on all files
  • adding revive to the nolint directive in context_test.go
  • adding a ReadHeaderTimeout to the server to protect against Slowloris attacks
  • a few comments ending in lists that got cleaned up with gofmt
  • removed the utc option in the logger code since its declared as true everywhere in the code and the editing of end inside that function was resulting in an unused variable linter error
  • changing all usages of io/ioutil to be either io or os

@ecrupper ecrupper requested a review from a team as a code owner September 12, 2022 17:03
@ecrupper ecrupper self-assigned this Sep 12, 2022
@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #693 (a1caac5) into master (7e9cfa2) will decrease coverage by 0.00%.
The diff coverage is 64.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #693      +/-   ##
==========================================
- Coverage   55.10%   55.09%   -0.01%     
==========================================
  Files         201      201              
  Lines       15960    15959       -1     
==========================================
- Hits         8794     8793       -1     
  Misses       6788     6788              
  Partials      378      378              
Impacted Files Coverage Δ
api/build.go 1.64% <0.00%> (ø)
api/log.go 0.00% <ø> (ø)
api/metrics.go 0.00% <ø> (ø)
api/pagination.go 0.00% <ø> (ø)
api/repo.go 0.00% <ø> (ø)
api/service.go 0.00% <ø> (ø)
api/step.go 0.00% <ø> (ø)
api/stream.go 0.00% <ø> (ø)
api/webhook.go 0.00% <0.00%> (ø)
compiler/native/native.go 83.72% <ø> (ø)
... and 53 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants