-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance(repo)!: add topics field to build env and repo #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecrupper
changed the title
enhance(repo): add topics field to build env and repo
enhance(repo)!: add topics field to build env and repo
Apr 7, 2023
Codecov Report
@@ Coverage Diff @@
## main #807 +/- ##
==========================================
- Coverage 57.91% 57.79% -0.13%
==========================================
Files 263 263
Lines 15862 15908 +46
==========================================
+ Hits 9187 9194 +7
- Misses 6261 6300 +39
Partials 414 414
|
ecrupper
commented
Apr 8, 2023
plyr4
reviewed
Apr 14, 2023
Co-authored-by: dave vader <[email protected]>
plyr4
previously approved these changes
Apr 14, 2023
wass3rw3rk
requested changes
Apr 14, 2023
wass3rw3rk
previously approved these changes
Apr 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
wass3rw3rk
approved these changes
Apr 14, 2023
plyr4
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes go-vela/community#774
Adds topics to build env and repo object. Dependent on go-vela/types#285
I noticed that we utilize
GetRepoForOrg
twice in thePostWebhook
function even though we do not update the repo object at all between those two calls. Therefore, I decided to remove the second DB call.I also took the liberty of abstracting repository event handling in our webhook API func. I saw it as very messy and distracting (it's ok to say that because I wrote it)
I wanted to retroactively adjust repos that have been enabled prior to this change by adding a topics setter call to
Repo.Topics
in thescm/github/webhook.go
process functions. Thego-github
library only hasTopics
available for events other thanpush
: google/go-github#2742. Once there is another release, we can add this same functionality to push events.