fix(scm): handle new go-github validation changes and ensure correct number for init hook #822
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the release of go-github/v51, the
ValidatePayload
method now requires secret validation in order to capture a payload (ref).Since our webhook validation occurs later, when we actually have our webhook secret, we cannot grab this payload unless we call
ValidatePayloadFromBody
with empty signature and secret values instead.Lastly, in this change, I failed to account for situations where a repo was being re-enabled / repaired, and thus the
init
webhook would not have a number value of1