Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(database): return build object on created and updated #884

Merged
merged 4 commits into from
Jun 15, 2023

Conversation

ecrupper
Copy link
Contributor

Continuing effort from these: #861, #882

@ecrupper ecrupper requested a review from a team as a code owner June 13, 2023 17:02
@ecrupper ecrupper self-assigned this Jun 13, 2023
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #884 (6469247) into main (e06d557) will increase coverage by 0.04%.
The diff coverage is 63.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #884      +/-   ##
==========================================
+ Coverage   71.31%   71.36%   +0.04%     
==========================================
  Files         303      303              
  Lines       12366    12363       -3     
==========================================
+ Hits         8819     8823       +4     
+ Misses       3117     3110       -7     
  Partials      430      430              
Impacted Files Coverage Δ
api/build/cancel.go 0.00% <0.00%> (ø)
api/build/clean.go 0.00% <0.00%> (ø)
api/build/plan.go 0.00% <0.00%> (ø)
api/build/publish.go 0.00% <0.00%> (ø)
api/build/update.go 0.00% <0.00%> (ø)
database/build/create.go 86.95% <85.71%> (+1.24%) ⬆️
database/build/update.go 86.95% <85.71%> (+1.24%) ⬆️

cognifloyd
cognifloyd previously approved these changes Jun 13, 2023
database/build/create.go Show resolved Hide resolved
database/build/update.go Show resolved Hide resolved
Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants