Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check for nil service and step #214

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

JordanSussman
Copy link
Collaborator

@JordanSussman JordanSussman requested a review from a team as a code owner December 6, 2021 15:25
@codecov
Copy link

codecov bot commented Dec 6, 2021

Codecov Report

Merging #214 (2e2fe97) into master (4dc404f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #214   +/-   ##
=======================================
  Coverage   96.70%   96.71%           
=======================================
  Files          53       53           
  Lines        5589     5595    +6     
=======================================
+ Hits         5405     5411    +6     
  Misses        137      137           
  Partials       47       47           
Impacted Files Coverage Δ
yaml/service.go 90.62% <100.00%> (+0.46%) ⬆️
yaml/step.go 95.58% <100.00%> (+0.20%) ⬆️

Copy link
Collaborator

@wass3r wass3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KellyMerrick KellyMerrick merged commit 4424c44 into go-vela:master Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic when pipeline contains nil step
3 participants