feat(library): add ServiceFromBuildContainer() #226
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially a copy of #205
This adds a
ServiceFromBuildContainer()
function to thegithub.com/go-vela/types/library
package:types/library/service.go
Lines 503 to 528 in 240fd4a
Similar to
StepFromBuildContainer()
, that was added in the above PR, this will be used in the go-vela/worker codebase.Also, following along with the above PR,
ServiceFromContainer
was renamed toServiceFromContainerEnvironment
.