fix(secret)!: remove implicit repo secrets and clean up secrets testing #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #230 +/- ##
==========================================
+ Coverage 97.06% 97.18% +0.11%
==========================================
Files 53 53
Lines 5797 5818 +21
==========================================
+ Hits 5627 5654 +27
+ Misses 125 121 -4
+ Partials 45 43 -2
|
|
It was an accidental merge. Just prior to it we decided to freeze current state across core repos for the RC unless they were dependency upgrades. |
kneal
reviewed
Feb 8, 2022
wass3r
changed the title
wass3r
changed the title
GregoryDosh
approved these changes
Feb 18, 2022
wass3r
approved these changes
Feb 18, 2022
|
@KellyMerrick anything else needed here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is to create a net-new pr for #210, which was reverted in #229. That pr was for a breaking change, that we decided not to introduce into an RC to be cut today.