Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support stages with templates #237

Merged
merged 6 commits into from
Mar 10, 2022
Merged

Conversation

JordanSussman
Copy link
Collaborator

@JordanSussman JordanSussman commented Feb 28, 2022

Add support for utilizing stages within templates.

xref: go-vela/community#233

@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #237 (a200806) into master (f76e06d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #237   +/-   ##
=======================================
  Coverage   97.17%   97.17%           
=======================================
  Files          53       53           
  Lines        5836     5838    +2     
=======================================
+ Hits         5671     5673    +2     
  Misses        122      122           
  Partials       43       43           
Impacted Files Coverage Δ
yaml/template.go 73.68% <ø> (ø)
yaml/metadata.go 92.68% <100.00%> (+0.37%) ⬆️

@JordanSussman JordanSussman marked this pull request as ready for review March 7, 2022 19:53
@JordanSussman JordanSussman requested a review from a team as a code owner March 7, 2022 19:53
@kneal kneal changed the title Poc/stages/templates feat: support stages with templates Mar 7, 2022
@kneal kneal added the feature Indicates a new feature label Mar 7, 2022
Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ecrupper ecrupper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JordanSussman JordanSussman merged commit 215407e into master Mar 10, 2022
@JordanSussman JordanSussman deleted the poc/stages/templates branch March 10, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Indicates a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants