fix(actions): make sure to use latest Go version #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #270 +/- ##
=======================================
Coverage 96.93% 96.93%
=======================================
Files 57 57
Lines 6301 6301
=======================================
Hits 6108 6108
Misses 143 143
Partials 50 50 |
|
confirmed that this is now pulling in the newest version: https://github.com/go-vela/types/actions/runs/3205048265/jobs/5237076830#step:3:11 |
This was referenced Oct 7, 2022
plyr4
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
waiting for actions/go-versions#60 to get merged to pull in 1.19.2 instead of 1.19.1 because that's what check_latest looks at to get the newest version.
I validated that this is need by rerunning https://github.com/go-vela/types/actions/runs/3171645351/jobs/5232434827 after the fix above was merged. It still pulled in the cached 1.19.1 version of Go.
We will want to apply this to all repos
(EDIT: ✅ PRs have been created)