Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(secret): use allow event system #341

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper commented Jan 3, 2024

It will be helpful to share the same structure for allowed events for both repos and secrets.

@ecrupper ecrupper requested a review from a team as a code owner January 3, 2024 22:12
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (26e54c8) 96.20% compared to head (bdaa6c0) 96.18%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #341      +/-   ##
==========================================
- Coverage   96.20%   96.18%   -0.02%     
==========================================
  Files          68       69       +1     
  Lines        7370     7417      +47     
==========================================
+ Hits         7090     7134      +44     
  Misses        205      205              
- Partials       75       78       +3     
Files Coverage Δ
database/secret.go 100.00% <100.00%> (ø)
library/actions/comment.go 92.30% <ø> (ø)
library/actions/push.go 100.00% <ø> (ø)
library/actions/schedule.go 100.00% <100.00%> (ø)
library/repo.go 100.00% <ø> (+2.30%) ⬆️
library/secret.go 100.00% <100.00%> (ø)
library/events.go 80.00% <69.76%> (-4.79%) ⬇️

Copy link
Member

@wass3rw3rk wass3rw3rk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first pass..

also, i didn't verify, but is checkEvents() actually unused as the linter claims? we can remove, if so.

library/actions/schedule.go Outdated Show resolved Hide resolved
library/actions/schedule.go Outdated Show resolved Hide resolved
@ecrupper
Copy link
Contributor Author

ecrupper commented Jan 3, 2024

first pass..

also, i didn't verify, but is checkEvents() actually unused as the linter claims? we can remove, if so.

The linter really does have its moments

wass3rw3rk
wass3rw3rk previously approved these changes Jan 5, 2024
@ecrupper ecrupper merged commit a91bd54 into main Jan 5, 2024
10 checks passed
@ecrupper ecrupper deleted the enhance/secrets/allow-events branch January 5, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants