-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance(secret): use allow event system #341
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #341 +/- ##
==========================================
- Coverage 96.20% 96.18% -0.02%
==========================================
Files 68 69 +1
Lines 7370 7417 +47
==========================================
+ Hits 7090 7134 +44
Misses 205 205
- Partials 75 78 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first pass..
also, i didn't verify, but is checkEvents() actually unused as the linter claims? we can remove, if so.
The linter really does have its moments |
It will be helpful to share the same structure for allowed events for both repos and secrets.