Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(database): add limit and eviction policy for deployment builds #355

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper commented Feb 5, 2024

Adding a limit + an eviction policy so we prioritize most recent builds for a given deployment.

@ecrupper ecrupper requested a review from a team as a code owner February 5, 2024 21:23
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (2b325c4) 96.64% compared to head (8a6212c) 96.56%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #355      +/-   ##
==========================================
- Coverage   96.64%   96.56%   -0.08%     
==========================================
  Files          69       69              
  Lines        5298     5305       +7     
==========================================
+ Hits         5120     5123       +3     
- Misses        106      109       +3     
- Partials       72       73       +1     
Files Coverage Δ
database/deployment.go 94.93% <42.85%> (-5.07%) ⬇️

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ecrupper ecrupper merged commit 8259493 into main Feb 6, 2024
11 checks passed
@ecrupper ecrupper deleted the fix/database/deploy-builds-limit branch February 6, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants