Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rulesets): add support for PR labeled events #361

Merged
merged 9 commits into from
Apr 2, 2024

Conversation

wsan3
Copy link
Contributor

@wsan3 wsan3 commented Mar 12, 2024

Description

Request for Vela to process and create builds for pull request labeled and unlabeled webhooks.

Related

GitHub issue #913
GitHub ideas #768

1. Add new action to the Pull struct
2. Update constants to reflect new event for the integer mask
3. Update YAML package to add new label rule
4. Update ruleset matching logic
@wsan3 wsan3 added the feature Indicates a new feature label Mar 12, 2024
@wsan3 wsan3 requested a review from a team as a code owner March 12, 2024 17:36
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 93.40659% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 96.54%. Comparing base (9b43c70) to head (7164ea7).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #361      +/-   ##
==========================================
- Coverage   96.55%   96.54%   -0.02%     
==========================================
  Files          69       69              
  Lines        5290     5330      +40     
==========================================
+ Hits         5108     5146      +38     
- Misses        109      110       +1     
- Partials       73       74       +1     
Files Coverage Δ
library/events.go 100.00% <100.00%> (ø)
webhook.go 100.00% <ø> (ø)
yaml/ruleset.go 100.00% <100.00%> (ø)
library/actions/pull.go 94.36% <90.90%> (-1.56%) ⬇️
pipeline/ruleset.go 81.81% <92.45%> (+0.37%) ⬆️

Copy link
Contributor

@ecrupper ecrupper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. One typo I noticed and that's it

library/actions/pull.go Outdated Show resolved Hide resolved
1. Add new action to the Pull struct
2. Update constants to reflect new event for the integer mask
3. Update YAML package to add new unlabeled rule
4. Update tests
pipeline/ruleset.go Outdated Show resolved Hide resolved
@wsan3 wsan3 marked this pull request as draft March 25, 2024 17:57
@wsan3 wsan3 marked this pull request as ready for review March 26, 2024 15:39
pipeline/ruleset.go Show resolved Hide resolved
pipeline/ruleset.go Show resolved Hide resolved
pipeline/ruleset.go Show resolved Hide resolved
pipeline/ruleset.go Show resolved Hide resolved
@wsan3 wsan3 merged commit f16c3e4 into main Apr 2, 2024
10 of 11 checks passed
@wsan3 wsan3 deleted the feat/pr-labeled-action branch April 2, 2024 15:37
@wsan3 wsan3 restored the feat/pr-labeled-action branch April 9, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Indicates a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants