-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rulesets): add support for PR labeled events #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add new action to the Pull struct 2. Update constants to reflect new event for the integer mask 3. Update YAML package to add new label rule 4. Update ruleset matching logic
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #361 +/- ##
==========================================
- Coverage 96.55% 96.54% -0.02%
==========================================
Files 69 69
Lines 5290 5330 +40
==========================================
+ Hits 5108 5146 +38
- Misses 109 110 +1
- Partials 73 74 +1
|
ecrupper
requested changes
Mar 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. One typo I noticed and that's it
1. Add new action to the Pull struct 2. Update constants to reflect new event for the integer mask 3. Update YAML package to add new unlabeled rule 4. Update tests
ecrupper
reviewed
Mar 25, 2024
plyr4
requested changes
Apr 2, 2024
plyr4
approved these changes
Apr 2, 2024
ecrupper
approved these changes
Apr 2, 2024
wass3rw3rk
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Request for Vela to process and create builds for pull request labeled and unlabeled webhooks.
Related
GitHub issue #913
GitHub ideas #768