Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete legacy allow event fields and methods #362

Merged
merged 3 commits into from
Apr 1, 2024

Conversation

ecrupper
Copy link
Contributor

v0.23 kept these fields around in case of need for reverting. With v0.24 slotted as our next release, we can pursue removing these unused fields

@ecrupper ecrupper requested a review from a team as a code owner March 13, 2024 17:04
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.55%. Comparing base (476edfa) to head (7542b5b).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #362      +/-   ##
==========================================
- Coverage   96.61%   96.55%   -0.06%     
==========================================
  Files          69       69              
  Lines        5375     5290      -85     
==========================================
- Hits         5193     5108      -85     
  Misses        109      109              
  Partials       73       73              
Files Coverage Δ
database/repo.go 98.47% <ø> (-0.11%) ⬇️
database/secret.go 100.00% <ø> (ø)
library/repo.go 100.00% <100.00%> (ø)
library/secret.go 100.00% <ø> (ø)

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants