Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(yaml): remediate insecure/archived buildkite lib in favor of go-yaml v3 #386

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

ecrupper
Copy link
Contributor

Use yaml.Node to create our own MapSlice type that we were relying on with the buildkite/go-yamlV2 implementation. However, now anchors will work with stages, as is made obvious by the passing tests that came from #12.

@ecrupper ecrupper requested a review from a team as a code owner August 13, 2024 15:42
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@772b29b). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Files Patch % Lines
yaml/stage.go 90.90% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #386   +/-   ##
=======================================
  Coverage        ?   96.02%           
=======================================
  Files           ?       69           
  Lines           ?     5382           
  Branches        ?        0           
=======================================
  Hits            ?     5168           
  Misses          ?      138           
  Partials        ?       76           
Files Coverage Δ
library/string.go 100.00% <ø> (ø)
yaml/stage.go 96.42% <90.90%> (ø)

Copy link
Contributor

@timhuynh94 timhuynh94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants