This repository has been archived by the owner on Sep 7, 2021. It is now read-only.
This repository is currently being migrated. It's locked while the migration is in progress.
update github.com/go-sql-driver/mysql to version 1.4.0 #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1000 +/- ##
=======================================
Coverage 54.29% 54.29%
=======================================
Files 41 41
Lines 7548 7548
=======================================
Hits 4098 4098
Misses 2934 2934
Partials 516 516Continue to review full report at Codecov.
|
|
Maybe remove the vendor directory is better. |
|
@lunny I think no because what if dependency updates in way that breaks this lib. Better to have known versions of dependency so downstream won't break upstream. Please correct me if I have a wrong though. |
|
Closed because #1016 is better approach |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will eventually resolve: go-gitea/gitea#3876