Make yaml.Node.Decode customizable with decoder options #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victor-perov
suggested changes
Feb 7, 2024
go.mod
Outdated
| @@ -1,4 +1,4 @@ | |||
| module "gopkg.in/yaml.v3" | |||
| module "github.com/tonickkozlov/yaml" | |||
There was a problem hiding this comment.
I think this is a leftover of local testing?
kvap
approved these changes
Feb 9, 2024
|
This breaks the existing API. |
|
See #1008 which is an alternate implementation which doesn't break the existing API. |
|
Hi and thanks for your review.Could you please elaborate on how is this change breaking the API?On 21 Feb 2024, at 14:55, Olivier Mengué ***@***.***> wrote:
This breaks the existing API.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #460