fix: simple keys until 1024 characters #1037
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@niemeyer any chance this PR could be merged soon? Thanks |
|
@niemeyer , any chance you can have a look? |
|
@niemeyer ping |
Prashansa-K
added a commit
to Kong/yaml
that referenced
this pull request
Sep 6, 2024
Currently, if a key is >128 characters, it is handled as a complex key mapping. This renders some OpenAPI spec paths invalid. Until the same PR go-yaml#1037 is not accepted in the upstream repository, we are adding the changes in this fork and will be using this in deck. Fixes: Kong/go-apiops#198
This was referenced Sep 6, 2024
|
We have now reverted to a fork, but would be nice to switch back. @niemeyer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #849
closes #1031