fix: only use performance.now when it is available #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickharris
changed the title
tommoor
changed the title
tommoor
approved these changes
Apr 14, 2020
|
Makes sense. Thanks @rickharris! |
berezovskyicom
pushed a commit
that referenced
this pull request
Apr 20, 2020
* fix: add import perfomance from perf_hooks (Node v8.5.0+) * only take perf measurements when we know we need them (#252) Co-authored-by: Vladimir Berezovsky <[email protected]> Co-authored-by: Rick Harris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposing an alternate solution to #251, since we're not sure if node's
perf_toolsmodule is going to work in the browser. We know that this will give us what we need for the internal analytics reporting, and doing it this way won't break for node users. If we need to make this public in the future, we can find a way to use eitherperf_toolsorwindow.performancedepending on whether the consumer is a browser or a node environment, but I think this is probably what we need for now.