Finder glob pattern #421
Merged
Finder glob pattern #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lisachenko
requested changes
Jun 27, 2019
.gitignore
Outdated
| @@ -3,3 +3,4 @@ composer.lock | |||
| phpunit.xml | |||
| tests/Fixtures/project/var/cache/* | |||
| build/ | |||
| .idea | |||
There was a problem hiding this comment.
Please, don't add IDE-specific folders into the project's .gitignore. Configure global gitignore instead, see https://help.github.com/en/articles/ignoring-files#create-a-global-gitignore
|
The inspection completed: No new issues |
lisachenko
approved these changes
Jun 28, 2019
|
Squashed and merged into 2.x, thanks! |
lisachenko
added a commit
that referenced
this pull request
Jun 28, 2019
* origin/2.x: Finder glob pattern (#421)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The former change of spl file iterators to symfony finder didn't have support for glob patterns (or possibly broke the former support)
This change is supposed to add support for glob patterns into the include_paths config section