Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent trying to access an entry when none exist. #1898

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

Kurochi51
Copy link
Contributor

I'm not quite sure what's the root cause, but I noticed this error gets spammed in the very first few seconds of the game launching post-injection.

[ERR] [WindowSystem] Error during Draw(): TitleScreenMenuOverlay
System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')
at System.SZArrayHelper.get_Item[T](Int32 index)
at Dalamud.Interface.Internal.Windows.TitleScreenMenuWindow.Draw() in C:\goatsoft\companysecrets\dalamud\Interface\Internal\Windows\TitleScreenMenuWindow.cs:line 273
at Dalamud.Interface.Windowing.Window.DrawInternal(DalamudConfiguration configuration) in C:\goatsoft\companysecrets\dalamud\Interface\Windowing\Window.cs:line 346

It seems to be because this.titleScreenMenu.PluginEntries is empty, although I didn't notice a behaviour change when this was changed in #1808, so I'm unsure if it's a coincidence, or a side effect of the many changes that happened recently.

@Kurochi51 Kurochi51 requested a review from a team as a code owner July 5, 2024 17:57
@goaaats goaaats merged commit 6992336 into goatcorp:master Jul 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants