Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Add-Feature] Add custom DXVK_HUD option #1119

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

quasd
Copy link

@quasd quasd commented Aug 25, 2022

I basically have no idea what I am doing (dotnet?), if there is anything you would like to be changed let me know.

The current options for DXVK_HUD were not enough so I implemented custom switch for it.

image
image
Only visible when set to custom:
image

Result in game:
image

Tested on: arch
build with customized: https://aur.archlinux.org/packages/xivlauncher-git

@quasd quasd changed the title [Add-Feature] Add custom dxvk_overlay option [Add-Feature] Add custom DXVK_HUD option Aug 25, 2022
@@ -276,7 +277,7 @@ public static void CreateCompatToolsInstance()
{
var wineLogFile = new FileInfo(Path.Combine(storage.GetFolder("logs").FullName, "wine.log"));
var winePrefix = storage.GetFolder("wineprefix");
var wineSettings = new WineSettings(Config.WineStartupType, Config.WineBinaryPath, Config.WineDebugVars, wineLogFile, winePrefix, Config.ESyncEnabled, Config.FSyncEnabled);
var wineSettings = new WineSettings(Config.WineStartupType, Config.WineBinaryPath, Config.DxvkHudCustomString, Config.WineDebugVars, wineLogFile, winePrefix, Config.ESyncEnabled, Config.FSyncEnabled);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a better idea to not put dxvk related config into WineSettings, especially considering since we just pass DxvkHudType and DxvkAsyncEnabled into the CompatibilityTools ctor currently.

Ideally DxvkHudCustomString is in there as well, or even better just put all dxvk related settings into their own class like DxvkSettings ,

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also consider that dxvk can also be used on windows, even though this is currently not in the scope of what XL provides it is possible, and for example an option in the GShade windows installer

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using dxvk on Windows is something we should never support. (It also will crash dalamud)

It honestly led to a support nightmare when the gshade installer started providing it as an option.

DXVK options should only be available for Wine platforms.

@@ -24,10 +25,11 @@ public class WineSettings

public DirectoryInfo Prefix { get; private set; }

public WineSettings(WineStartupType? startupType, string customBinPath, string debugVars, FileInfo logFile, DirectoryInfo prefix, bool? esyncOn, bool? fsyncOn)
public WineSettings(WineStartupType? startupType, string customBinPath, string dxvkHudCustomString, string debugVars, FileInfo logFile, DirectoryInfo prefix, bool? esyncOn, bool? fsyncOn)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit nit-picky but there is an extra space before FileInfo here (well and it is better to not have dxvk stuff here as well)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants