Unify Dalamud injector arguments #1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotNite
approved these changes
Jan 15, 2023
| { | ||
| public static class DalamudInjectorArgs | ||
| { | ||
| public const string Launch = "launch"; |
There was a problem hiding this comment.
These consts don't match our style guide, but I think we should focus on fixing this later with the Great Goatcorp Lint Bonanza.
goaaats
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the issues with the
UNIXDalamud injector arguments being very out of date by moving both theWindowsandUNIXarguments into one class.goatcorp/XIVLauncher.Core#28 is blocked by this PR
CC: @NotNite