Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update name of redistributable package to download #1354

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Dormanil
Copy link
Contributor

@Dormanil Dormanil commented Jul 3, 2023

Ever since Microsoft released a new version of Visual Studio, there has been a change to the name of the Visual C++ Redistributable. I think it is about time we updated our language, especially since people don't necessarily know that we are telling them outdated information.

This also renames the localisation key. If you don't want that, I can undo that particular change.

@KazWolfe
Copy link
Member

KazWolfe commented Jul 3, 2023

Looks like this may be an annoying pain, but it would be awesome if we could include a button/link to the file specifically. Is there any way we can hack that in? (at-maintainers)

@reiichi001
Copy link
Contributor

We already have a FAQ to cover it, when it does come up.

Otherwise, that one SquirrelSetup fork can technically check/enforce it, but we don't typically run into this very often given SquirrelSetup itself will also generally fail if the VC Redist is missing entirely. (This check really just ensures the user has one that covers everything Dalamud needs instead of some ancient install of just vcrun2015 or something)

It's possible to add a link or button on the error popup message if they made it past Squirrel, but I'm not sure if we entirely need it. https://aka.ms/vs/17/release/vc_redist.x64.exe is available as a permalink from Microsoft, as the runtime installer hasn't changed since 2015.

@Dormanil
Copy link
Contributor Author

Dormanil commented Jul 3, 2023

That link is nice and good, but it's not always been the same link ever since 2015. Replacing the 17 with a 15 results in the 2017 installer, and replacing it with a 16 results in the 2015-2019 one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants