-
-
Notifications
You must be signed in to change notification settings - Fork 907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
website/integrations: Fix incorrect size redefinition for Discord avatar acquisition code. #11050
Conversation
Signed-off-by: Aterfax <[email protected]>
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for authentik-storybook canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11050 +/- ##
==========================================
+ Coverage 92.69% 92.76% +0.06%
==========================================
Files 736 736
Lines 36425 36425
==========================================
+ Hits 33763 33788 +25
+ Misses 2662 2637 -25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* main: (30 commits) website/docs: prepare release notes for 2024.8 (#11011) translate: Updates for file web/xliff/en.xlf in zh_CN (#11070) translate: Updates for file web/xliff/en.xlf in zh-Hans (#11071) web: bump mermaid from 10.9.1 to 11.0.2 in /web (#11066) core: bump github.com/jellydator/ttlcache/v3 from 3.2.0 to 3.2.1 (#11059) Fix incorrect size redefinition for Discord avatar acquisition code. (#11050) core, web: update translations (#11051) website: bump micromatch from 4.0.5 to 4.0.8 in /website (#11052) core: bump django-pglock from 1.5.1 to 1.6.0 (#11058) core: bump goauthentik.io/api/v3 from 3.2024063.13 to 3.2024064.1 (#11060) core: bump github.com/prometheus/client_golang from 1.20.1 to 1.20.2 (#11061) web: bump the swc group across 2 directories with 11 updates (#11062) web: bump tslib from 2.6.3 to 2.7.0 in /web (#11063) web: bump @eslint/js from 9.9.0 to 9.9.1 in /web (#11064) web: bump syncpack from 12.4.0 to 13.0.0 in /web (#11065) web: bump @goauthentik/api from 2024.6.3-1724337552 to 2024.6.3-1724414734 in /web/sfe (#11067) web: Provide tests for the aggregate cards, fix a few minor things (#9744) enterprise: fix license status progress bar (#11048) root: backport version bump (#11045) web/flows: update flow background (#11044) ...
* web/element/ak-select-table: website/docs: prepare release notes for 2024.8 (#11011) translate: Updates for file web/xliff/en.xlf in zh_CN (#11070) translate: Updates for file web/xliff/en.xlf in zh-Hans (#11071) web: bump mermaid from 10.9.1 to 11.0.2 in /web (#11066) core: bump github.com/jellydator/ttlcache/v3 from 3.2.0 to 3.2.1 (#11059) Fix incorrect size redefinition for Discord avatar acquisition code. (#11050) core, web: update translations (#11051) website: bump micromatch from 4.0.5 to 4.0.8 in /website (#11052) core: bump django-pglock from 1.5.1 to 1.6.0 (#11058) core: bump goauthentik.io/api/v3 from 3.2024063.13 to 3.2024064.1 (#11060) core: bump github.com/prometheus/client_golang from 1.20.1 to 1.20.2 (#11061) web: bump the swc group across 2 directories with 11 updates (#11062) web: bump tslib from 2.6.3 to 2.7.0 in /web (#11063) web: bump @eslint/js from 9.9.0 to 9.9.1 in /web (#11064) web: bump syncpack from 12.4.0 to 13.0.0 in /web (#11065) web: bump @goauthentik/api from 2024.6.3-1724337552 to 2024.6.3-1724414734 in /web/sfe (#11067) web: Provide tests for the aggregate cards, fix a few minor things (#9744) enterprise: fix license status progress bar (#11048) root: backport version bump (#11045)
Details
Apologies for the follow up given the recent merged PR, but it looks like there's a spurious redefinition that has still been causing issues after conducting some more tests with users today.
tl;dr if we defined the avatar size, the code should not arbitrarily add a new
size=NN
suffix.Checklist
ak test authentik/
)make lint-fix
)If an API change has been made
make gen-build
)If changes to the frontend have been made
make web
)If applicable
make website
)