Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website/integrations: Fix incorrect size redefinition for Discord avatar acquisition code. #11050

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

Aterfax
Copy link
Contributor

@Aterfax Aterfax commented Aug 23, 2024

Details

Apologies for the follow up given the recent merged PR, but it looks like there's a spurious redefinition that has still been causing issues after conducting some more tests with users today.

tl;dr if we defined the avatar size, the code should not arbitrarily add a new size=NN suffix.

image


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@Aterfax Aterfax requested a review from a team as a code owner August 23, 2024 21:32
Copy link

netlify bot commented Aug 23, 2024

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 3d8a5d9
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/66c8fffa37aabc0008013c5b
😎 Deploy Preview https://deploy-preview-11050--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 23, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 3d8a5d9
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/66c8fffa36feef0008d4203e

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.76%. Comparing base (a6225ad) to head (3d8a5d9).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11050      +/-   ##
==========================================
+ Coverage   92.69%   92.76%   +0.06%     
==========================================
  Files         736      736              
  Lines       36425    36425              
==========================================
+ Hits        33763    33788      +25     
+ Misses       2662     2637      -25     
Flag Coverage Δ
e2e 49.26% <ø> (+0.10%) ⬆️
integration 25.01% <ø> (ø)
unit 90.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu changed the title Fix incorrect size redefinition for Discord avatar acquisition code. website/integrations: Fix incorrect size redefinition for Discord avatar acquisition code. Aug 26, 2024
@BeryJu BeryJu merged commit 5d2d9c9 into goauthentik:main Aug 26, 2024
67 of 68 checks passed
kensternberg-authentik added a commit that referenced this pull request Aug 26, 2024
* main: (30 commits)
  website/docs: prepare release notes for 2024.8 (#11011)
  translate: Updates for file web/xliff/en.xlf in zh_CN (#11070)
  translate: Updates for file web/xliff/en.xlf in zh-Hans (#11071)
  web: bump mermaid from 10.9.1 to 11.0.2 in /web (#11066)
  core: bump github.com/jellydator/ttlcache/v3 from 3.2.0 to 3.2.1 (#11059)
  Fix incorrect size redefinition for Discord avatar acquisition code. (#11050)
  core, web: update translations (#11051)
  website: bump micromatch from 4.0.5 to 4.0.8 in /website (#11052)
  core: bump django-pglock from 1.5.1 to 1.6.0 (#11058)
  core: bump goauthentik.io/api/v3 from 3.2024063.13 to 3.2024064.1 (#11060)
  core: bump github.com/prometheus/client_golang from 1.20.1 to 1.20.2 (#11061)
  web: bump the swc group across 2 directories with 11 updates (#11062)
  web: bump tslib from 2.6.3 to 2.7.0 in /web (#11063)
  web: bump @eslint/js from 9.9.0 to 9.9.1 in /web (#11064)
  web: bump syncpack from 12.4.0 to 13.0.0 in /web (#11065)
  web: bump @goauthentik/api from 2024.6.3-1724337552 to 2024.6.3-1724414734 in /web/sfe (#11067)
  web: Provide tests for the aggregate cards, fix a few minor things (#9744)
  enterprise: fix license status progress bar (#11048)
  root: backport version bump (#11045)
  web/flows: update flow background (#11044)
  ...
kensternberg-authentik added a commit that referenced this pull request Aug 27, 2024
* web/element/ak-select-table:
  website/docs: prepare release notes for 2024.8 (#11011)
  translate: Updates for file web/xliff/en.xlf in zh_CN (#11070)
  translate: Updates for file web/xliff/en.xlf in zh-Hans (#11071)
  web: bump mermaid from 10.9.1 to 11.0.2 in /web (#11066)
  core: bump github.com/jellydator/ttlcache/v3 from 3.2.0 to 3.2.1 (#11059)
  Fix incorrect size redefinition for Discord avatar acquisition code. (#11050)
  core, web: update translations (#11051)
  website: bump micromatch from 4.0.5 to 4.0.8 in /website (#11052)
  core: bump django-pglock from 1.5.1 to 1.6.0 (#11058)
  core: bump goauthentik.io/api/v3 from 3.2024063.13 to 3.2024064.1 (#11060)
  core: bump github.com/prometheus/client_golang from 1.20.1 to 1.20.2 (#11061)
  web: bump the swc group across 2 directories with 11 updates (#11062)
  web: bump tslib from 2.6.3 to 2.7.0 in /web (#11063)
  web: bump @eslint/js from 9.9.0 to 9.9.1 in /web (#11064)
  web: bump syncpack from 12.4.0 to 13.0.0 in /web (#11065)
  web: bump @goauthentik/api from 2024.6.3-1724337552 to 2024.6.3-1724414734 in /web/sfe (#11067)
  web: Provide tests for the aggregate cards, fix a few minor things (#9744)
  enterprise: fix license status progress bar (#11048)
  root: backport version bump (#11045)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants