Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: extract object matching from flow manager #11458

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

rissson
Copy link
Member

@rissson rissson commented Sep 20, 2024

Details

Extracted from #10815. Makes the code generic and re-usable elsewhere, like the kerberos source sync code.


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@rissson rissson self-assigned this Sep 20, 2024
@rissson rissson requested a review from a team as a code owner September 20, 2024 13:26
Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit fb1b4aa
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/66ed77febb64bd0008a33743

Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit fb1b4aa
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/66ed77ff84aa1e000839e24b

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 98.79518% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.66%. Comparing base (849951e) to head (fb1b4aa).
Report is 157 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
authentik/core/sources/matcher.py 98.61% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11458      +/-   ##
==========================================
- Coverage   92.73%   92.66%   -0.08%     
==========================================
  Files         736      737       +1     
  Lines       36492    36510      +18     
==========================================
- Hits        33841    33832       -9     
- Misses       2651     2678      +27     
Flag Coverage Δ
e2e 49.20% <60.24%> (-0.04%) ⬇️
integration 25.02% <27.71%> (+0.02%) ⬆️
unit 90.21% <98.79%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-fb1b4aa8b9e7503f761e14525dd00f987a3a3ad4
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-fb1b4aa8b9e7503f761e14525dd00f987a3a3ad4-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-fb1b4aa8b9e7503f761e14525dd00f987a3a3ad4

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-fb1b4aa8b9e7503f761e14525dd00f987a3a3ad4-arm64

Afterwards, run the upgrade commands from the latest release notes.

@rissson rissson enabled auto-merge (squash) September 20, 2024 14:24
@rissson rissson mentioned this pull request Sep 23, 2024
14 tasks
@BeryJu BeryJu changed the title sources: extract object matching from flow manager core: extract object matching from flow manager Oct 17, 2024
@rissson rissson merged commit b57df12 into main Oct 17, 2024
71 checks passed
@rissson rissson deleted the source-flow-manager-extract-matching-code branch October 17, 2024 12:21
kensternberg-authentik added a commit that referenced this pull request Oct 18, 2024
* main: (68 commits)
  core: extract object matching from flow manager (#11458)
  admin: store version history (#11520)
  web: bump API Client version (#11706)
  providers/oauth2: add initial JWE support (#11344)
  core, web: update translations (#11703)
  tests/e2e: add forward auth e2e test (#11374)
  web/admin: fix duplicate flow labels (#11689)
  providers/saml: fix incorrect ds:Reference URI (#11699)
  website/docs: Fix websocket default config for nginx proxy manager (#11621)
  core, web: update translations (#11692)
  core: bump uvicorn from 0.31.1 to 0.32.0 (#11693)
  core: bump github.com/prometheus/client_golang from 1.20.4 to 1.20.5 (#11694)
  website/docs: add missing file to sidebar (#11695)
  website/docs: rewrote too long sentence (#11696)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in fr (#11697)
  translate: Updates for file web/xliff/en.xlf in fr (#11698)
  stages/authenticator_webauthn: Update FIDO MDS3 & Passkey aaguid blobs (#11683)
  core, web: update translations (#11682)
  core: bump github.com/getsentry/sentry-go from 0.29.0 to 0.29.1 (#11684)
  core: bump github.com/redis/go-redis/v9 from 9.6.1 to 9.6.2 (#11685)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants