Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providers/proxy: fix traefik label generation #11460

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

dandrade-wave
Copy link
Contributor

related to this issue: https://github.com/goauthentik/authentik/issues/9786

In the current version the outpost is creating a docker label like this:

traefik.http.routers.ak-outpost-whoami-router.rule="(Host(``whoami.localhost``)) && PathPrefix(`/outpost.goauthentik.io`)"

the double quote on host gives a error on traefik.

@dandrade-wave dandrade-wave requested a review from a team as a code owner September 20, 2024 16:06
Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 73c9481
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/66ed9d7a79e91b0008ee174a

Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 73c9481
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/66ed9d7acc677900085b9413

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.73%. Comparing base (f386856) to head (73c9481).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11460      +/-   ##
==========================================
+ Coverage   92.66%   92.73%   +0.07%     
==========================================
  Files         736      736              
  Lines       36492    36492              
==========================================
+ Hits        33814    33841      +27     
+ Misses       2678     2651      -27     
Flag Coverage Δ
e2e 49.24% <ø> (+0.11%) ⬆️
integration 24.99% <ø> (ø)
unit 90.20% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu changed the title fix: proxy provider - docker traefik label providers/proxy: fix traefik label generation Sep 23, 2024
@BeryJu
Copy link
Member

BeryJu commented Sep 23, 2024

/cherry-pick version-2024.8

@BeryJu BeryJu added this to the Release 2024.8.3 milestone Sep 23, 2024
@BeryJu BeryJu merged commit ffcd146 into goauthentik:main Sep 23, 2024
68 checks passed
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Sep 23, 2024
BeryJu pushed a commit that referenced this pull request Sep 23, 2024
…11480)

fix: proxy provider - docker traefik label (#11460)

Signed-off-by: Diogo Andrade <[email protected]>
Co-authored-by: Diogo Andrade <[email protected]>
kensternberg-authentik added a commit that referenced this pull request Sep 24, 2024
… into web/policy-wizard-3

* origin/core/app-transactional/bindings: (47 commits)
  improve permission checks
  core: add support to set policy bindings in transactional endpoint
  web/admin: fix Authentication flow being required (#11496)
  web: bump the wdio group across 2 directories with 5 updates (#11494)
  web: bump turnstile-types from 1.2.2 to 1.2.3 in /web (#11495)
  web: bump the swc group across 2 directories with 11 updates (#11493)
  web: bump the eslint group across 2 directories with 5 updates (#11492)
  web: bump the storybook group across 1 directory with 7 updates (#11491)
  core: bump bandit from 1.7.9 to 1.7.10 (#11485)
  web: bump the rollup group across 2 directories with 3 updates (#11487)
  web: bump @types/node from 22.5.5 to 22.6.1 in /web (#11490)
  website/docs: use a more consistent version requirement notice (#11400)
  website/docs: clarify API browser access (#11373)
  website/integrations: Glitchtip: update redirect URL (#11438)
  web: bump knip from 5.30.4 to 5.30.5 in /web (#11479)
  fix: proxy provider - docker traefik label (#11460)
  website: the requirements for Go and Node required updating. (#11419)
  web: bump the esbuild group across 1 directory with 3 updates (#11470)
  web: bump @sentry/browser from 8.30.0 to 8.31.0 in /web in the sentry group across 1 directory (#11478)
  web: bump the eslint group across 2 directories with 1 update (#11469)
  ...
kensternberg-authentik added a commit that referenced this pull request Sep 25, 2024
* main: (146 commits)
  website: bump @types/react from 18.3.8 to 18.3.9 in /website (#11502)
  core: bump debugpy from 1.8.5 to 1.8.6 (#11503)
  core: bump google-api-python-client from 2.146.0 to 2.147.0 (#11504)
  web: bump @types/node from 22.6.1 to 22.7.0 in /web (#11505)
  core, web: update translations (#11500)
  sources/ldap: fix mapping check, fix debug endpoint (#11442)
  web/admin: fix Authentication flow being required (#11496)
  web: bump the wdio group across 2 directories with 5 updates (#11494)
  web: bump turnstile-types from 1.2.2 to 1.2.3 in /web (#11495)
  web: bump the swc group across 2 directories with 11 updates (#11493)
  web: bump the eslint group across 2 directories with 5 updates (#11492)
  web: bump the storybook group across 1 directory with 7 updates (#11491)
  core: bump bandit from 1.7.9 to 1.7.10 (#11485)
  web: bump the rollup group across 2 directories with 3 updates (#11487)
  web: bump @types/node from 22.5.5 to 22.6.1 in /web (#11490)
  website/docs: use a more consistent version requirement notice (#11400)
  website/docs: clarify API browser access (#11373)
  website/integrations: Glitchtip: update redirect URL (#11438)
  web: bump knip from 5.30.4 to 5.30.5 in /web (#11479)
  fix: proxy provider - docker traefik label (#11460)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants