recreate error with only ipfs-utils, not ipfs-core #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gobengo
changed the title
|
I believe it was caused because unintended typescript declarations were genrated for glob-source that said it returned an AsyncIterator({ content: fs.ReadStream }), even though the authored js includes in the jsdoc |
achingbrain
pushed a commit
to ipfs/js-ipfs-utils
that referenced
this pull request
Apr 19, 2022
Motivation: * Fix ipfs/js-ipfs#4080 * tl;dr * fix `import globSourceImport from 'ipfs-utils/src/files/glob-source.js'` from typescript * fix importing ipfs-core from typescript Context: * microsoft/TypeScript#23857 Strategy * Use jsdoc `@return` instead of `@yields` because tsc doesn't understand that `@yields` implies a `@return` type Test Case * gobengo/ipfs-core-esm-test#3 * I tested locally with `npm link` and this seemed to fix it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.