Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/sirupsen/logrus from 1.8.1 to 1.9.0 #64

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 19, 2022

Bumps github.com/sirupsen/logrus from 1.8.1 to 1.9.0.

Commits
  • f8bf765 Merge pull request #1343 from sirupsen/dbd-upd-dep
  • ebc9029 update dependencies
  • 56c843c Merge pull request #1337 from izhakmo/fix-cve
  • 41b4ee6 update gopkg.in/yaml.v3 to v3.0.1
  • f98ed3e Merge pull request #1333 from nathanejohnson/bumpxsys
  • 2b8f60a bump version of golangci-lint
  • 0db10ef bump version of golang.org/x/sys dependency
  • 85981c0 Merge pull request #1263 from rubensayshi/fix-race
  • 79c5ab6 Merge pull request #1283 from sirupsen/dbd-log-doc
  • 5f8c666 Improve Log methods documentation
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependency Pull requests that update a dependency file go labels Jul 19, 2022
@sio4
Copy link
Member

sio4 commented Jul 19, 2022

  • This update for logrus includes CVE update as the PR description indicated (gopkg.in/yaml.v3 to v3.0.1) but all buffalo family modules already updated with the new version of gopkg.in/yaml.v3 v3.0.1 except packd.
  • buffalo-pop and cli indirectly depend on logger module already and I think we need to migrate it to use logger.

Keep this PR open, but I will check if migrating them to logger could be better or not.

@sio4 sio4 self-assigned this Jul 19, 2022
@@ -12,7 +12,7 @@ require (
github.com/gobuffalo/plush/v4 v4.1.13
github.com/gobuffalo/pop/v6 v6.0.6
github.com/gofrs/uuid v4.2.0+incompatible
github.com/sirupsen/logrus v1.8.1
github.com/sirupsen/logrus v1.9.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will check this dependency could be removed.

@sio4
Copy link
Member

sio4 commented Jul 19, 2022

It seems like sirupsen/logrus#1343 reverted CVE-related fix sirupsen/logrus#1337. Not for now.

Bumps [github.com/sirupsen/logrus](https://github.com/sirupsen/logrus) from 1.8.1 to 1.9.0.
- [Release notes](https://github.com/sirupsen/logrus/releases)
- [Changelog](https://github.com/sirupsen/logrus/blob/master/CHANGELOG.md)
- [Commits](sirupsen/logrus@v1.8.1...v1.9.0)

---
updated-dependencies:
- dependency-name: github.com/sirupsen/logrus
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/sirupsen/logrus-1.9.0 branch from 16da232 to b2b10f9 Compare July 26, 2022 15:27
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 26, 2022

Looks like github.com/sirupsen/logrus is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Aug 26, 2022
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/sirupsen/logrus-1.9.0 branch August 26, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant