Skip to content
This repository has been archived by the owner on Jun 25, 2022. It is now read-only.

Removing “envy” dependency? #45

Closed
dcelasun opened this issue Feb 7, 2018 · 0 comments
Closed

Removing “envy” dependency? #45

dcelasun opened this issue Feb 7, 2018 · 0 comments

Comments

@dcelasun
Copy link

dcelasun commented Feb 7, 2018

Depending on envy to get the GOPATH introduces a long chain of dependencies that could be avoided. Something like:

func GoPath() string {
	p := strings.Split(os.Getenv("GOPATH"), string(os.PathListSeparator))
	if len(p) == 0 || p[0] == "" {
		return build.Default.GOPATH
	}
	return p[0]
}

Would it be possible to switch to something like this? Using packr in a project that vendors and commits its dependencies adds a lot of unnecessary files.

dinedal pushed a commit to dinedal/packr that referenced this issue Feb 8, 2018
Closes gobuffalo#45

Credit to @dcelasun for the basis of the code
dinedal pushed a commit to dinedal/packr that referenced this issue Feb 8, 2018
Closes gobuffalo#45

Credit to @dcelasun for the basis of the code
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant