Tadpole operator to String#match?
#802
Conversation
Codecov Report
@@ Coverage Diff @@
## master #802 +/- ##
==========================================
+ Coverage 80.26% 80.91% +0.65%
==========================================
Files 54 54
Lines 7397 7419 +22
==========================================
+ Hits 5937 6003 +66
+ Misses 1235 1191 -44
Partials 225 225
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
@hachi8833 this looks great! thanks for the work! But I will hold the merge a little longer because it's a breaking change.
|
No problem! I leave this to you. |
There was a problem hiding this comment.
Rubocop style guides also suggests that
=~is not (partially) recommended: https://github.com/rubocop-hq/ruby-style-guide#no-perl-regexp-last-matchers
My understanding of that guide section is that it suggests not to use numbered captures - the expression with the tadpole (/(regexp)/ =~ string) is just something they use as example.
Regardless of this, I'm very used to the operator, but I also use Perl a lot 😂, so 👍 for the change.
|
@hachi8833 I think this can go out in version |
|
Thank you! |
This is just my idea that the tadpole operator
=~looks cryptic and is a legacy from Perl, so changing this tomatch?is better for clarification.Rubocop style guides also suggests that
=~is not (partially) recommended: https://github.com/rubocop-hq/ruby-style-guide#no-perl-regexp-last-matchersIf unnecessary, just discard the PR.
Thank you,