Remove included calendars from gem

[JoeSouthan]

Why?

• We now have 2 different packages for managing business date calculations: gocardless/business-python, keeping the data up to date between them will prove more and more difficult
• The vast majority of users do not need all of the included calendars

Migration

If you currently use any of the bundled calendars, please copy them to a folder within your project root - Existing calendar data can be found here

For example:

Before:

Business::Calendar.load("bacs")

After 2.0

Business::Calendar.load_paths("lib/calendars") # lib/calendars contains bacs.yml
Business::Calendar.load("bacs")

[ahjmorton]

I'd add a second sentence here pointing to the old data in Github as a set of files.

Potentially a second in the README along the lines of "Hey, how do I unbreak now you've unbundled the data?"

[JoeSouthan]

Will do!

[ahjmorton]

maybe with a message along the lines of "this data only goes until 2020, after that you're on your own"

[dchambersgc]

The changes to remove the inbuilt directories are good.

The README needs to be looked at again, theres a few spelling mistakes and the flow isn't the smoothest for a reader. We could simplify the flow if we talk about using the calendar in one place, currently we mention it twice in slightly different ways, we also have a new change included in v2 half way through the README after we have talked about the other changes in v2 at the top.

[dchambersgc]

Some further thoughts. It's reading a lot better so thank you for that.

[dchambersgc]

Some smaller suggestions, it's coming together nicely.

[dchambersgc]

@JoeSouthan One thing to be aware of, we have typo'd the gem api in the PR description. It should read Business::Calendar instead of Calendar::Business

[JoeSouthan]

@dchambersgc Whoops! corrected the pr and the readme