Add rubocop check to CI #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benk-gc
force-pushed
the
benk--apply-rubocop
branch
3 times, most recently
from
7f07215
to
33dd034
Compare
stephenbinns
reviewed
Jul 8, 2024
benk-gc
force-pushed
the
benk--apply-rubocop
branch
from
33dd034
to
4c33d68
Compare
benk-gc
force-pushed
the
benk--apply-rubocop
branch
from
4c33d68
to
684768e
Compare
Tabby
reviewed
Jul 9, 2024
Tabby
approved these changes
Jul 9, 2024
Fixes an annoying issue with rubygems which spams warnings when running certain commands. See rubygems/rubygems#5016
benk-gc
force-pushed
the
benk--apply-rubocop
branch
from
684768e
to
77482aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although we have
rubocopavailable we never actually run it as part of the CI workflow, and as a result errors can creep in as new code is committed. This adds a CI linting check, and fixes all existing errors.