Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go.mod to v5 #172

Merged
merged 2 commits into from
Aug 26, 2019
Merged

Update go.mod to v5 #172

merged 2 commits into from
Aug 26, 2019

Conversation

bminer
Copy link
Contributor

@bminer bminer commented Aug 8, 2019

Closes #125

@bminer
Copy link
Contributor Author

bminer commented Aug 8, 2019

Once merged, please tag the release v6.0.0. Thank you!

@bminer
Copy link
Contributor Author

bminer commented Aug 8, 2019

After I thought about this a little bit, I think we could safely change this to v5 and release under tag v5.0.2.

Running go get github.com/godbus/dbus/v5 would never match 5.0.0 or 5.0.1 because they are technically invalid semver tags according to Go.

@bminer
Copy link
Contributor Author

bminer commented Aug 8, 2019

Let me know what the best course of action is here.

@jsouthworth
Copy link
Member

Just so I'm clear, are you proposing using v5 instead of v6 in the .mod file and having me tag that as v5.0.2?

If that is the case then that seems the right way to go.

@titanous
Copy link

Would it be possible to get the v5 change/tag pushed soon? This currently breaks downstream consumers using go mod.

@bminer
Copy link
Contributor Author

bminer commented Aug 26, 2019

@jsouthworth - Yes. v5 in the go.mod. Tag as 5.0.2. All users should then see dbus/v5 as v5.0.2.

@jsouthworth
Copy link
Member

@bminer can you update the PR with v5. Then I'll merge and tag a release.

@bminer
Copy link
Contributor Author

bminer commented Aug 26, 2019

Yes. Doing it now...

@bminer bminer changed the title Update go.mod to v6 Update go.mod to v5 Aug 26, 2019
@jsouthworth jsouthworth merged commit 735b987 into godbus:master Aug 26, 2019
@jsouthworth
Copy link
Member

Thanks @bminer, the release has now been tagged.

@bminer
Copy link
Contributor Author

bminer commented Aug 26, 2019

Thank you, sir!

@jsouthworth
Copy link
Member

Unfortunately, it looks like there is still something missing here. I set up a simple test and end up with:

module jsouthworth.net/go/test

go 1.12

require (
	github.com/godbus/dbus v4.1.0+incompatible // indirect
	github.com/godbus/dbus/v5 v5.0.2 // indirect
)

This is probably because we have imports in the submodules that don't reference v5.

@bminer
Copy link
Contributor Author

bminer commented Aug 29, 2019

@jsouthworth - Could be another submodule like you say, but you can always try go mod tidy and see if it fixes things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go.mod doesn't follow requirements
3 participants