Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] Make sure the multi-view container fills the page #19

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Nov 29, 2023

When the implicit view is disabled (PR), the multi-view container has a height of 0 (don't ask me, ask CSS).

This PR makes sure that the multi-view container can fill the page on its own without needing the side effect of the implicit view to do so.

@mdebbar mdebbar mentioned this pull request Nov 29, 2023
Copy link
Owner

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@goderbauer goderbauer merged commit 94dfac0 into goderbauer:main Nov 29, 2023
@mdebbar mdebbar deleted the stretch_multiview_web branch February 1, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants