Skip to content

Commit

Permalink
Add CI checks against todo comments without issues
Browse files Browse the repository at this point in the history
  • Loading branch information
chitoyuu committed Dec 7, 2022
1 parent ffe6fc2 commit ce18d8c
Showing 1 changed file with 15 additions and 0 deletions.
15 changes: 15 additions & 0 deletions .github/workflows/minimal-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ env:
# Don't use more features like "gdnative_bindings_generator/debug" to keep CI truly minimal
GDRUST_FEATURES: "gdnative/async,gdnative/serde"

RIPGREP_VERSION: "13.0.0"

on:
pull_request:
branches:
Expand Down Expand Up @@ -52,6 +54,19 @@ jobs:
- name: "Check clippy"
run: cargo clippy --workspace --features ${GDRUST_FEATURES} -- -D clippy::style -D clippy::complexity -D clippy::perf -D clippy::dbg_macro -D clippy::todo -D clippy::unimplemented

check-todo:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: "Install ripgrep"
run: |
cd /tmp
wget --no-verbose https://github.com/BurntSushi/ripgrep/releases/download/${RIPGREP_VERSION}/ripgrep-${RIPGREP_VERSION}-x86_64-unknown-linux-musl.tar.gz -O ripgrep.tar.gz
tar -zxvf ripgrep.tar.gz
sudo mv ripgrep-${RIPGREP_VERSION}-x86_64-unknown-linux-musl/rg /usr/bin
- name: "Look for TODO comments without issue numbers attached to them"
run: "! rg -iTh --pcre2 '(?<!clippy::)(TODO|FIXME)(?!!\\(\\)|\\((#|(\\w+/)+)\\d+\\))'"

unit-test:
runs-on: ubuntu-latest
steps:
Expand Down

0 comments on commit ce18d8c

Please sign in to comment.