Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Godot 3.5 support #910

Merged
merged 12 commits into from
Oct 2, 2022
Merged

Godot 3.5 support #910

merged 12 commits into from
Oct 2, 2022

Conversation

Bromeon
Copy link
Member

@Bromeon Bromeon commented Jul 17, 2022 •
edited
Loading

Integrates support for Godot 3.5.1, including:

Godot

  • Updated api.json + XML documentation
  • Version compatibility warning to avoid accidental mix-ups
  • CI suite for new engine version (+ support for RCs)
  • Backwards compatibility down to Godot 3.2, when using custom-godot feature

Rust

  • MSRV 1.63
  • Updated crate dependencies

This was referenced Jul 17, 2022
Closed
Closed
@Bromeon Bromeon added the feature Adds functionality to the library label Jul 17, 2022
@Bromeon
Copy link
Member Author

Bromeon commented Aug 5, 2022

Godot 3.5 has been released as per announcement. I'll see if I find some time soon to look into this.

If anyone can help with #894 (reproduce, debug, etc) that would be hugely appreciated. If I work alone on this, it will likely delay GDExtension.

@Cheeseness Cheeseness mentioned this pull request Aug 6, 2022
Closed
@crabdancing
Copy link

This looks pretty good to me. I pulled and compiled, and the logic of the demos seems to be working fine as well. :)

@goblinJoel goblinJoel mentioned this pull request Aug 13, 2022
Closed
@voice-of-texnoforge
Copy link

I've used

gdnative = { git = "https://github.com/Bromeon/godot-rust.git", branch = "feature/godot-3.5" }

and it seems to work fine for my simple demo.

Thanks for working on this 👌🏿

@Bromeon
Copy link
Member Author

Bromeon commented Aug 31, 2022

bors try

bors bot added a commit that referenced this pull request Aug 31, 2022
@bors
Try #910:
8f25e27
@bors
Copy link
Contributor

bors bot commented Aug 31, 2022

try

Build failed:

@Bromeon
Copy link
Member Author

Bromeon commented Aug 31, 2022

bors try

bors bot added a commit that referenced this pull request Aug 31, 2022
@bors
Try #910:
ec466d4
@bors
Copy link
Contributor

bors bot commented Aug 31, 2022

try

Build failed:

@Bromeon
Copy link
Member Author

Bromeon commented Aug 31, 2022

bors try

bors bot added a commit that referenced this pull request Aug 31, 2022
@bors
Try #910:
c84eb04
@bors
Copy link
Contributor

bors bot commented Aug 31, 2022

try

Build succeeded:

@Bromeon Bromeon mentioned this pull request Sep 3, 2022
Closed
@Bromeon Bromeon force-pushed the feature/godot-3.5 branch 2 times, most recently from f0dcde4 to 18754a6 Compare September 6, 2022 21:48
@Bromeon
Copy link
Member Author

Bromeon commented Sep 6, 2022

Updated api.json and XML docs to Godot 3.5.1 RC1.
It probably makes sense to merge this, once that bugfix release sees the light of day.

bors try

bors bot added a commit that referenced this pull request Sep 6, 2022
@bors
Try #910:
082185b
@godot-rust godot-rust deleted a comment from bors bot Sep 6, 2022
@Bromeon
Copy link
Member Author

Bromeon commented Sep 6, 2022 •
edited
Loading

Jobs failed due to GitHub outage and lack of network connectivity.

bors retry

@Bromeon
Copy link
Member Author

Bromeon commented Sep 6, 2022

bors try-
bors retry

@bors
Copy link
Contributor

bors bot commented Sep 7, 2022

try

Timed out.

@Bromeon
Copy link
Member Author

Bromeon commented Sep 7, 2022

bors try

bors bot added a commit that referenced this pull request Sep 7, 2022
@bors
Try #910:
89e0867
@Bromeon Bromeon added c: bindings Component: GDNative bindings (mod api) c: ci Component: CI and automation labels Sep 7, 2022
@bors
Copy link
Contributor

bors bot commented Sep 7, 2022

try

Build succeeded:

@Bromeon
Copy link
Member Author

Bromeon commented Sep 7, 2022

bors try

bors bot added a commit that referenced this pull request Sep 7, 2022
@bors
Try #910:
c0ab7d1
@Bromeon Bromeon added this to the v0.11 milestone Sep 7, 2022
@bors
Copy link
Contributor

bors bot commented Sep 7, 2022

try

Build succeeded:

@Bromeon
Copy link
Member Author

Bromeon commented Sep 7, 2022

bors try

bors bot added a commit that referenced this pull request Sep 7, 2022
@bors
Try #910:
ef193b5
@bors
Copy link
Contributor

bors bot commented Sep 7, 2022

try

Build succeeded:

@Bromeon Bromeon added the breaking-change Issues and PRs that are breaking to fix/merge. label Sep 18, 2022
@Bromeon Bromeon mentioned this pull request Sep 18, 2022
Closed
@Bromeon
Copy link
Member Author

Bromeon commented Sep 28, 2022

Godot 3.5.1-stable has been released 20min ago, not even an announcement yet! 🙂

So the way is free for this. Please bring up any last-minute remarks.

@Bromeon Bromeon marked this pull request as ready for review September 28, 2022 08:45
@Bromeon
Remove Transform2D::from_rotation_translation_scale()
a6e5025 
The constructor is unintuitive, has no GDScript equivalent and will need to be reworked.
The plan is to bring back a more "idiomatic" way of constructing Transform2D, similar to glam::Affine2D::from_scale_angle_translation():

https://docs.rs/glam/0.21.3/glam/f32/struct.Affine2.html#method.from_scale_angle_translation
@Bromeon
Update docs and api.json for Godot 3.5.1-stable
c5fd091
@Bromeon
Merge branch 'master' into feature/godot-3.5
bbdf54b 
# Conflicts:
#	README.md
#	gdnative-core/src/core_types/geom/transform2d.rs
@Bromeon
Copy link
Member Author

Bromeon commented Oct 2, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 2, 2022

Build succeeded:

@bors bors bot merged commit 8ed2e11 into godot-rust:master Oct 2, 2022
@Bromeon Bromeon deleted the feature/godot-3.5 branch October 2, 2022 11:00
@chitoyuu chitoyuu modified the milestones: v0.11.x, v0.11.1 Dec 6, 2022
@Bromeon Bromeon mentioned this pull request Jan 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking-change Issues and PRs that are breaking to fix/merge. c: bindings Component: GDNative bindings (mod api) c: ci Component: CI and automation feature Adds functionality to the library
Projects
None yet
Milestone
v0.11.1
Development

Successfully merging this pull request may close these issues.
4 participants
@Bromeon @crabdancing @voice-of-texnoforge @chitoyuu