Add achievement rarity to GameCenter plugin #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Calinou Any interest in taking this one in? |
|
This looks good to me, but CI is failing. |
ddossot
force-pushed
the
gc-achievement-rarity-percent
branch
from
a5fe31a
to
8995bc7
Compare
ddossot
commented
Nov 13, 2023
|
|
||
| NSNumber *number; | ||
| #ifdef __IPHONE_17_0 | ||
| if (@available(iOS 17.0, *)) { |
There was a problem hiding this comment.
We need both the macro and the availability checks, the former to allow building on pre-17.0 SDKs and the latter to silence compilation warnings when building on >17.0.
There was a problem hiding this comment.
Something like this will probably work without ifdefs (property should have default getter with the same name):
if ([description respondsToSelector:@selector(rarityPercent)]) {
number = [description performSelector:@selector(rarityPercent)];
}There was a problem hiding this comment.
Much better, great suggestion! I confirmed this works with iOS 17.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Support the
rarityPercentproperty that was added toGKAchievementDescriptionin iOS 17.0.Doc: https://developer.apple.com/documentation/gamekit/gkachievementdescription/4273663-raritypercent
Changes
rarity_percentsto theachievement_descriptionsevent dictionary and wire the value from the newly introduced property,-1if the iOS version is below 17.0 or if the achievement doesn't have a rarity percent value (i.e.nilis provided by GameKit).Testing
Tested with Godot 3.5.0 and iOS 17, fetching achievements that have and do not have rarities.