[SCons] Remove use_clang_cl windows flag in favor of generic use_llvm #1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is consistent with Godot upstream.
Faless
added
enhancement
dsnopek
approved these changes
Sep 26, 2024
|
Cherry-picked for 4.2 in PR #1631 |
|
Cherry-picked for 4.3 in PR #1632 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is consistent with Godot upstream.
As discussed in #1601 (comment) it seems that we have a discrepancy between upstream Godot and godot-cpp which uses a special
use_clang_clinstead of the genericuse_llvmflag for building Windows with the clang MSVC backend.