Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add p_use_model_front to Basis::looking_at() #1625

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Add p_use_model_front to Basis::looking_at() #1625

merged 1 commit into from
Oct 17, 2024

Conversation

Flarkk
Copy link
Contributor

@Flarkk Flarkk commented Oct 14, 2024

This PR aligns the prototype and implementation of Basis::looking_at() with the Godot version of this function.
Fixes #1624

@Flarkk Flarkk requested a review from a team as a code owner October 14, 2024 19:51
aaronfranke
aaronfranke approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches what's in the engine.

dsnopek
dsnopek approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dsnopek dsnopek added enhancement This is an enhancement on the current functionality cherrypick:4.2 cherrypick:4.3 labels Oct 17, 2024
@dsnopek dsnopek added this to the 4.x milestone Oct 17, 2024
@dsnopek dsnopek merged commit 96675a8 into godotengine:master Oct 17, 2024
12 checks passed
@Flarkk Flarkk deleted the looking_at branch October 17, 2024 14:39
@dsnopek
Copy link
Collaborator

dsnopek commented Oct 28, 2024

Cherry-picked for 4.2 in PR #1631

@dsnopek
Copy link
Collaborator

dsnopek commented Oct 28, 2024

Cherry-picked for 4.3 in PR #1632

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsnopek dsnopek dsnopek approved these changes

@aaronfranke aaronfranke aaronfranke approved these changes

Assignees
No one assigned
Labels
enhancement This is an enhancement on the current functionality
Projects
None yet
Milestone
4.x
Development

Successfully merging this pull request may close these issues.

Basis::looking_at() does not expose parameter use_model_front
3 participants
@Flarkk @dsnopek @aaronfranke