Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extension for 4.0 #39

Closed
wants to merge 1 commit into from
Closed

Conversation

raulsntos
Copy link
Member

@raulsntos raulsntos commented Feb 15, 2022

Although these changes should fix the extension for 4.0 while keeping support for 3.x, they feel hacky and it might be better to simply provide a configuration setting for the user that defaults to the current stable version of Godot instead of trying to detect the version.

Closes #38

@neikeq
Copy link
Contributor

neikeq commented Feb 16, 2022

In a week, we'll be merging the dotnet6 branch to master and this will no longer work. I can merge this if still desired, though.

@raulsntos
Copy link
Member Author

I don't see how these specific changes are related to that merge, unless you mean that Godot 4.0 will be unusable due to the many things that were commented out and that need to be rewritten, in which case I still think these changes would eventually be needed, no?

Either way, I'm in no hurry to merge this as 4.0 is still in alpha, just looked into it because somebody asked and thought I'd leave this here for when we need it.

@neikeq
Copy link
Contributor

neikeq commented Feb 16, 2022

I don't see how these specific changes are related to that merge

The extension uses the Mono debugger, which won't be usable in 4.x because the editor (including the player) uses CoreCLR (as it uses the runtime from the .NET Sdk). This means the VS debugger won't be able to connect, which I think results in a launch error.

- The `.mono` folder was moved to `.godot/mono`
- The `--remote-debug` argument now requires the protocol
- The `-q` argument has been repurposed, now `--quit` should be used
@Kezzo
Copy link

Kezzo commented Dec 21, 2022

Hey! ✌️
What's the status of this PR?

Godot 4.0 seems to be getting closer to release and is in bugfixing mode now. So there shouldn't be any big changes on the C# side anymore.
If we don't want to deal with backwards compatibility for Godot 3.x right now, we could still release a preview package of this with Godot 4.0 support to get feedback and bug reports already coming in!

@raulsntos
Copy link
Member Author

Superseded by #56

@raulsntos raulsntos closed this Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only attach works with Godot 4.0
3 participants