Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshots are broken on asset library due to file name/format change #895

Closed
GuillaumeOz opened this issue Mar 27, 2023 · 3 comments
Closed
Labels

Comments

@GuillaumeOz
Copy link

GuillaumeOz commented Mar 27, 2023

Hi,

PNG is missing to this url :

https://godotengine.org/asset-library/asset/132

Error : 404 not found

@Calinou
Copy link
Member

Calinou commented Mar 27, 2023

Demos use WebP screenshots in the master branch, but we should modify screenshot URLs to reflect the state of the demos in Godot 3.5 anyway. This means using the 3.5 branch instead of master for icon URLs.

This will require going through all official demos one by one. I've fixed RichTextLabel so far.

@Calinou Calinou changed the title Png is missing Screenshots are broken on asset library due to file name/format change Mar 27, 2023
@InfiniteProductions
Copy link
Contributor

I would like to help @Calinou, just to be sure to understand before working on this, the goal is to convert all screenshots into webp format and update all readme accordingly, right ?

Is there any preferred settings ? (compression level, lossless, etc)

@Calinou
Copy link
Member

Calinou commented May 27, 2023

I resolved this issue yesterday, so this issue can now be closed. (Resolving this issue required editing assets on the asset library, so you had to have moderator privileges.)

@Calinou Calinou closed this as completed May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants