Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload 4.x demos to the asset library #920

Open
diguifi opened this issue May 20, 2023 · 5 comments
Open

Upload 4.x demos to the asset library #920

diguifi opened this issue May 20, 2023 · 5 comments
Labels

Comments

@diguifi
Copy link

diguifi commented May 20, 2023

Which demo project is affected:
godotengine/godot-demo-projects/tree/master/3d/platformer

OS/device including version:
_

Issue description:
The project is tagged as 3.5 at the asset store, when it has been updated to version 4 recently. I think this is an important matter since I and many others have been targeting v4 only on the asset store.

Screenshots of issue:
image
image

@diguifi diguifi added the bug label May 20, 2023
@Calinou
Copy link
Member

Calinou commented May 20, 2023

The 4.0 demos aren't uploaded to the asset library yet. Note that some demos weren't ported to 4.0 yet, so not all 3.x demos have a working 4.0 counterpart yet.

@Calinou Calinou changed the title Demo project mistakenly tagged as version 3.5 instead of 4 at the asset store Upload 4.0 demos to the asset library May 20, 2023
@Calinou Calinou mentioned this issue Nov 16, 2023
@Calinou Calinou changed the title Upload 4.0 demos to the asset library Upload 4.x demos to the asset library Feb 7, 2024
@Calinou Calinou pinned this issue Mar 24, 2024
@Calinou
Copy link
Member

Calinou commented Mar 24, 2024

As per the tracker, there are still a few demos pending an update so we can upload all 4.x demos at once on the asset library. These can prove to be difficult to update in a fully functional manner, so maybe it's better to upload what works now and upload the rest later once they're ported. I'll look into doing this at some point.

@Calinou
Copy link
Member

Calinou commented Mar 28, 2024

All 4.2 demos are now on the asset library, with a few exceptions as these demos are currently not functional in the master branch:

  • 3D IK Demo
  • UI Mirroring Demo
  • 2.5D with C# Demo
  • Android In-App Purchases with C# Demo
  • Dodge the Creeps with C# Demo
  • Pong Multiplayer with C# Demo
  • WebRTC Minimal Connection Demo
  • WebRTC Signaling Demo

@mhilbrunner
Copy link
Member

The HDR demo likewise seems to be missing. Should we update the descriptions of the outdated 3.x entries on the Asset Lib to link to the 4.x versions?

@Calinou
Copy link
Member

Calinou commented Apr 8, 2024

The HDR demo likewise seems to be missing. Should we update the descriptions of the outdated 3.x entries on the Asset Lib to link to the 4.x versions?

It's called Glow for 2D in 4.x as it no longer relies on HDR (since HDR in 2D was removed in 4.0 and only reimplemented in 4.2).

The demo will eventually be updated to optionally use HDR in 2D, but we can't make it a hard requirement of the demo as HDR in 2D isn't available in the Compatibility rendering method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants