Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VRAM leak in compositor effect demo #1115

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

RGDTAB
Copy link
Contributor

@RGDTAB RGDTAB commented Sep 16, 2024

The compositor effect demo was attempting to free data created by a RenderingDevice using the RenderingServer. RenderingDevice RIDs are not the same as RenderingServer RIDs, and can't be freed by the RenderingServer.

@Calinou Calinou added the bug label Sep 16, 2024
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected.

Thanks! Congratulations for your first merged pull request 🎉

@Calinou Calinou merged commit a87fded into godotengine:master Sep 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants