Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some GDScript files #1129

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

dalexeev
Copy link
Member

@dalexeev dalexeev commented Nov 2, 2024

  • Replace not X is Y with X is not Y.
    • This is supported since 4.3, so project.godot and *.import files for such projects have also been updated.
  • Replace # warning-ignore:X with @warning_ignore("X") and remove unnecessary warning ignores.
  • Convert comment keywords such as NOTE and BUG to uppercase (they are highlighted in the editor).

Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not totally happy with making a cosmetic change that makes the demos incompatible with earlier Godot releases, because it's a barrier to testing the latest demos on older Godot releases. I would personally wait a year or two for is not to have been out for awhile. But we can go forward with it if you prefer that.

The other changes are just good 👍

@dalexeev
Copy link
Member Author

dalexeev commented Nov 2, 2024

I would personally wait a year or two for is not to have been out for awhile.

We could put this in a separate PR if you prefer. I just thought that the master branch here is the same as in the main repository, and there are separate branches for 4.3 and 4.2. At least that's what the README says.

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Regarding version compatibility, it's fine for master to support only 4.3 and later (new demos can be 4.4-dev only too). We have stable branches for older releases.

@Calinou Calinou merged commit c492e5f into godotengine:master Nov 4, 2024
1 check passed
@dalexeev dalexeev deleted the update-some-gdscript branch November 4, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants