Prepared Autoload(Singletons) demo for Godot 4 #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89 tasks
aaronfranke
reviewed
Apr 3, 2022
loading/autoload/README.md
Outdated
| @@ -4,7 +4,7 @@ This demo shows how to use autoloads to change between scenes. | |||
|
|
|||
| Language: GDScript | |||
|
|
|||
| Renderer: GLES 2 | |||
| Renderer: Vulkan | |||
There was a problem hiding this comment.
If we're updating this text, we should be specifying if it's Vulkan Clustered or Vulkan Mobile.
Additionally, we should be setting demos to Vulkan Mobile if it doesn't look any different compared to Vulkan Clustered. Especially for GUI-only demos, they will look the same in Vulkan Mobile. Go to Project -> Project Settings -> General tab -> Rendering section -> Vulkan -> Back End -> Select Forward Mobile.
There was a problem hiding this comment.
Thanks! Fixed, squashed and pushed!
Not really any fixing were required, some data changed between versions when opening and testing everything. Did some changes to the project settings (2d to canvas_items). Everything works fine without problems. Change to Vulkan Mobile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not really any fixing were required, some data changed between versions
when opening and testing everything. Did some minor changes to the project
settings so the new Godot 4 terms are used.
Everything works fine without problems.